Talk:Avalanche

It's not clear to me why this set is being included as part of the invention system, given that it is not a craftable set. --AboveTheChemist (talk) 01:45, 12 September 2020 (UTC)

Because this (and a number of other) set is being pulled into pages like https://hcwiki.cityofheroes.dev/wiki/Category:Sets_that_improve_Fire_Defense And I'm trying to find what needs to be done to not break these lists. Michiyo (talk) 02:34, 12 September 2020 (UTC)

Understood. I knew that those pages existed and that there was an issue with the attuned enhancements (i.e winter and archetype) not being included properly, but given that the attuned enhancements aren't part of the invention system, I wasn't sure how to properly address it either. That's part of the reason I created the Set Bonus Comparison Tables page so that all of the enhancements, including attuned, could be compared. Given that most of the winter and archetype pages didn't exist, I used the few existing examples from the ones that did exist to create the winter enhancement pages, and I am just starting on the archetype enhancement pages. I don't have anywhere near the expertise to understand how the set summary pages (like the one you linked) are created, much less be able to modify the attuned enhancement pages to be able to pull in that info as well, but I agree that it would be nice if that worked for all enhancement types. If you can figure out the back end stuff to make it work, I am happy to propagate the necessary changes across the attuned enhancement pages, and/or help out in any other way as needed.

Also I was going to start a discussion on the forum (in the wiki club) but I'll hold off on that for now, in case there is a better place to discuss it.--AboveTheChemist (talk) 03:12, 12 September 2020 (UTC)

After giving it some thought and doing some research, I think perhaps some modifications to the Template:InvSetOverview template might take care of the issue. Specifically, I want to try adding one parameter to that template call, and adding some switch functions so that the top line that the template produces will differentiate between winter enhancements, archetype enhancements, and invention enhancements (which will be the default). I am going to take a stab at that now and if it doesn't work I'll revert the changes. --AboveTheChemist (talk) 19:05, 12 September 2020 (UTC)

I'm fairly pleased with how the results turned out. I modified Template:InvSetOverview as noted, and used Avalanche as the test set by modifying it to use the InvSetOverview template. Looking at Category:Sets that improve Fire Resistance for example, Avalanche now shows up, but there are two issues. The first was that the enhancement set icon was not displaying, and the second is that the individual enhancement drop symbols are not displaying. I was able to correct the former by adding a switch function to Template:InvSetOverviewSummary.dpl, and now it looks like the set icons display correctly. I also just realized that I need to make a few more modifications to those switch functions in Template:InvSetOverview in order to account for the superior versions of the WO and ATOs.

The second issue is trickier to correct (at least for me). It looks like it originates in Template:DropRecipeHeadPool.dpl and/or Template:DropRecipeHead. The issue seems to stem from the fact that the winter and archetype enhancements don't use the Template:DropRecipeHead that the invention enhancements use, because the winter and archetype enhancements don't use recipes. Instead, I created Template:WODropHead and Template:WODropHeadSuper for the winter enhancements, and Template:AODropHead and Template:AODropHeadSuper for the archetype enhancements. At first glance it seems that modifying Template:DropRecipeHead such that it is able to perform the functions of Template:WODropHead, Template:WODropHeadSuper, Template:AODropHead, and Template:AODropHeadSuper might correct the issue. But, it's not clear to me right now exactly how to do that, or if it is even feasible. I'll continue to look into the issue, though. --AboveTheChemist (talk) 21:00, 12 September 2020 (UTC)

I think these issues have now been corrected, see Template talk:DropRecipeHead (down at the bottom) for more information. --AboveTheChemist (talk) 03:45, 16 September 2020 (UTC)